Discussion:
[Gnash-commit] [bug #50462] Gnash shows weird version information when built from detached-HEAD Git repository
Nutchanon Wetchasit
2017-03-05 15:59:05 UTC
Permalink
URL:
<http://savannah.gnu.org/bugs/?50462>

Summary: Gnash shows weird version information when built
from detached-HEAD Git repository
Project: Gnash - The GNU Flash player
Submitted by: nachanon
Submitted on: Sun 05 Mar 2017 10:59:04 PM ICT
Category: build
Severity: 3 - Normal
Release: master
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any

_______________________________________________________

Details:

This is a minor issue, but it would be nice if it get fixed.

While I was going back and forth in local Gnash Git repository, I ran into
some oddity when I leave the repository in detatched HEAD mode (a la `git
checkout REVSHA1`): I found that Gnash built from that repository would show a
weird version string:

$ git checkout 144e082
Note: checking out '144e082'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

git checkout -b new_branch_name

HEAD is now at 144e082... Note fscommand support in MovieClip.getURL
$ ./autogen.sh && CC="ccache gcc" CXX="ccache g++" ./configure
--enable-media=ffmpeg,gst --enable-renderer=agg,cairo,opengl
--enable-gui=gtk,qt4,sdl,fb,dump --enable-docbook && make && su -c "make
install"

...Output omitted...

$ gnash --version
Gnash 0.8.11dev ((no-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.

Build options
Renderers: agg cairo opengl
Hardware Acceleration: RawFB
GUI: GTK
Media handlers: ffmpeg gst
Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
CXXFLAGS: -g -O2 -std=c++11 -W -Wall -Wcast-qual
-Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4
$


You would see that the branch part displayed in the version string is "(no",
which is not normal; and this oddity also show up in GTK-Gnash's About dialog
too (see the attached screenshot).

This problem does not seem to affect usability of the build, though it may
cause confusion when user try to report bugs in Gnash built from that kind of
repository configuration.

Gnash: 0.8.11dev (git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386




_______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 05 Mar 2017 10:59:04 PM ICT Name: aboutgnash_0.8.11dev-144e082.png
Size: 8kB By: nachanon
About Gnash dialog from Gnash 0.8.11dev git 144e082, built in detatched-HEAD
mode
<http://savannah.gnu.org/bugs/download.php?file_id=39895>

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-05 16:30:58 UTC
Permalink
Follow-up Comment #1, bug #50462 (project gnash):

This seems to boil down to how Gnash build script extracts branch information
from the repository...

Makefile.am:161
<https://git.savannah.gnu.org/cgit/gnash.git/tree/Makefile.am?id=144e0827072b746b2bedebe39ca8a7e0fb43a455#n161>:

nick="`cd $(top_srcdir) ; $(GIT) branch | grep '^\*' | cut -d ' ' -f 2`"; \


Running `git branch` in the repository after `git checkout 144e082` shows:

$ git branch
* (no branch)
master
$


Since what branch retrieval command did is finding line beginning with "*" and
use its 2nd column (separated by space). So "(no branch)" became "(no"
displayed in the version string:

$ git branch | grep '^\*' | cut -d ' ' -f 2
(no
$
-verbatim+

If a more modern version of git (e.g. 2.11.1) is used, output would be even
more weird:

$ git --version
git version 2.11.1
$ git branch
* (HEAD detached at 144e08270)
master
$ git branch | grep '^\*' | cut -d ' ' -f 2
(HEAD
$


Maybe a fix would involve changing the source of branch information from
porcelain `git branch` (which is prone to format changes) to something
low-level like `git symbolic-ref` (which is recommended for scripting).

Gnash: 0.8.11dev (git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
Git: 2.11.1 (source)
System: Debian GNU/Linux 7.0 Wheezy i386


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-05 16:34:23 UTC
Permalink
Follow-up Comment #2, bug #50462 (project gnash):

*Previous post's markup is messed up a bit, here is a repost:*

This oddity seems to boil down to how Gnash build script extracts branch
information from the repository...

Makefile.am:161
<https://git.savannah.gnu.org/cgit/gnash.git/tree/Makefile.am?id=144e0827072b746b2bedebe39ca8a7e0fb43a455#n161>:

nick="`cd $(top_srcdir) ; $(GIT) branch | grep '^\*' | cut -d ' ' -f 2`"; \


Running `git branch` in the repository after `git checkout 144e082` shows:

$ git branch
* (no branch)
master
$


Since what branch retrieval command did is finding line beginning with "*" and
use its 2nd column (separated by space). So "(no branch)" became "(no"
displayed in the version string:

$ git branch | grep '^\*' | cut -d ' ' -f 2
(no
$


If a more modern version of git (e.g. 2.11.1) is used, output would be even
more weird:

$ git --version
git version 2.11.1
$ git branch
* (HEAD detached at 144e08270)
master
$ git branch | grep '^\*' | cut -d ' ' -f 2
(HEAD
$


Maybe a fix would involve changing the source of branch information from
porcelain `git branch` (which is prone to format changes) to something
low-level like `git symbolic-ref` (which is recommended for scripting).

Gnash: 0.8.11dev (git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
Git: 2.11.1 (source)
System: Debian GNU/Linux 7.0 Wheezy i386


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-05 17:24:08 UTC
Permalink
Follow-up Comment #3, bug #50462 (project gnash):

And another question is: what branch nickname should be displayed when the
repository HEAD is not on any branch?

One possible choice is using "none"...

Gnash 0.8.11dev (none-22387-144e082)


Or use "unknown"...

Gnash 0.8.11dev (unknown-22387-144e082)


Or use a pre-written
<https://git.savannah.gnu.org/cgit/gnash.git/tree/configure.ac?id=144e0827072b746b2bedebe39ca8a7e0fb43a455#n20>
`$VERSION`...
(This is currently used when Gnash is built out of Git repository)

Gnash 0.8.11dev (0.8.11dev-22387-144e082)


Or omit the branch part and its following dash entirely...
(This would require changing how version string is built when such case is
encountered)

Gnash 0.8.11dev (22387-144e082)


Gnash: 0.8.11dev (git 144e082 22-Feb-2017)
System: Debian GNU/Linux 7.0 Wheezy i386


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-07 09:58:16 UTC
Permalink
Additional Item Attachment, bug #50462 (project gnash):

File name: 0001_use-git-symbolicref-for-revno-branch.patch Size:1 KB


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-07 10:01:17 UTC
Permalink
Additional Item Attachment, bug #50462 (project gnash):

File name: aboutgnash_0.8.11dev-144e082_noneplaceholder.png Size:8 KB


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-07 10:03:25 UTC
Permalink
Additional Item Attachment, bug #50462 (project gnash):

File name: 0001_use-git-symbolicref-for-revno-branch-unknown-placeholder.patch
Size:1 KB


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-07 10:04:32 UTC
Permalink
Additional Item Attachment, bug #50462 (project gnash):

File name: aboutgnash_0.8.11dev-144e082_unknownplaceholder.png Size:8 KB


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-07 10:06:22 UTC
Permalink
Additional Item Attachment, bug #50462 (project gnash):

File name: 0001_use-git-symbolicref-for-revno-branch-version-placeholder.patch
Size:1 KB


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-07 10:07:37 UTC
Permalink
Additional Item Attachment, bug #50462 (project gnash):

File name: aboutgnash_0.8.11dev-144e082_versionplaceholder.png Size:8 KB


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-07 10:12:49 UTC
Permalink
Follow-up Comment #4, bug #50462 (project gnash):

Patch included, see below.

These patches use a combination of `git symbolic-ref -q HEAD` and `basename`
to determine current branch. All of them do the same thing, but use a
different placeholder branch nickname when current branch cannot be
determined; only one can be chosen for inclusion in mainline.

Choice 1. Use "none" when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch.patch (file #39917)

Gnash 0.8.11dev (none-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.

Build options
Renderers: agg cairo opengl
Hardware Acceleration: RawFB
GUI: GTK
Media handlers: ffmpeg gst
Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
CXXFLAGS: -g -O2 -std=c++11 -W -Wall -Wcast-qual
-Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4

(Screenshot of About Gnash dialog: file #39918)

Choice 2. Use "unknown" when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch-unknown-placeholder.patch (file
#39919)

Gnash 0.8.11dev (unknown-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.

Build options
Renderers: agg cairo opengl
Hardware Acceleration: RawFB
GUI: GTK
Media handlers: ffmpeg gst
Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
CXXFLAGS: -g -O2 -std=c++11 -W -Wall -Wcast-qual
-Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4

(Screenshot of About Gnash dialog: file #39920)

Choice 3. Use pre-written version from configure.ac's `AC_INIT`
<https://git.savannah.gnu.org/cgit/gnash.git/tree/configure.ac?id=144e0827072b746b2bedebe39ca8a7e0fb43a455#n20>
when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch-version-placeholder.patch (file
#39921)

Gnash 0.8.11dev (0.8.11dev-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.

Build options
Renderers: agg cairo opengl
Hardware Acceleration: RawFB
GUI: GTK
Media handlers: ffmpeg gst
Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
CXXFLAGS: -g -O2 -std=c++11 -W -Wall -Wcast-qual
-Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4

(Screenshot of About Gnash dialog: file #39922)

Portability notes:

* A use of `basename` shouldn't be problem since `configure` is already using
it.
* `git symbolic-ref -q HEAD` works in expected manner at least in Git 1.5.6.5,
1.7.10.4, and 2.11.1.

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Sandro Santilli
2017-03-07 11:21:55 UTC
Permalink
Follow-up Comment #5, bug #50462 (project gnash):

How about picking a branch containing the commit ?
In the example case you're making I see "master" branch
does contain 144e082:

```
git branch --contains 144e082
```

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-07 13:07:28 UTC
Permalink
Follow-up Comment #6, bug #50462 (project gnash):

@strk,
In detached HEAD mode, `git branch --contains REVSHA1` does not seem to work
like expected:

$ git checkout 144e082
Note: checking out '144e082'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

git checkout -b new_branch_name

HEAD is now at 144e082... Note fscommand support in MovieClip.getURL
$ git branch
* (no branch)
master
$ git branch --contains 144e082
* (no branch)
master
$


You would see that the highlighted branch name is still "(no branch)".

Gnash: 0.8.11dev (git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Sandro Santilli
2017-03-07 13:38:48 UTC
Permalink
Follow-up Comment #7, bug #50462 (project gnash):

Ok with "none" then, but I've tried your patch and I get "none" even when I'm
on a valid branch. This is with Git 2.7.4 - note that both symbolic-ref -q
HEAD and basename work fine when invoked manually, so there must be another
issue (my build dir is outside the source dir, in case that matters)

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-08 09:43:17 UTC
Permalink
Follow-up Comment #8, bug #50462 (project gnash):

I have re-checked the patch with on-tree and off-tree building: the problem
seems to caused by an error on my part, sorry. (It's a mix-up between Make's
and Make's sub-shell variable)

From Makefile patched by original patch (file #39917):

nick="`basename "$(nick)"`"; \
if test -z "$(nick)"; then \
nick="none"; \
fi; \


It should have been...

nick="`basename "$${nick}"`"; \
if test -z "$${nick}"; then \
nick="none"; \
fi; \


As there's no Make variable named "nick", it causes branch nickname to always
be assigned as "none"; no matter that Git HEAD is currently on a valid branch
or not. On-tree V.S. off-tree building configuration is irrelevant in this
case.

I have attached the corrected patch as
`0001_use-git-symbolicref-for-revno-branch-v2.patch`.

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #39935)
_______________________________________________________

Additional Item Attachment:

File name: 0001_use-git-symbolicref-for-revno-branch-v2.patch Size:1 KB


_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Nutchanon Wetchasit
2017-03-08 09:48:21 UTC
Permalink
Follow-up Comment #9, bug #50462 (project gnash):

Build results of the fixed patch (file #39935) on my system are as follows...

On-tree build, 144e082 on `master` branch:

$ git checkout -f master && patch -i
/tmp/0001_use-git-symbolicref-for-revno-branch-v2.patch && ./autogen.sh &&
CC="ccache gcc" CXX="ccache g++" ./configure --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook && make

...Output omitted...

$ gui/gtk-gnash --version
Gnash 0.8.11dev (master-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.

Build options
Renderers: agg cairo opengl
Hardware Acceleration: RawFB
GUI: GTK
Media handlers: ffmpeg gst
Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
CXXFLAGS: -g -O2 -std=c++11 -W -Wall -Wcast-qual
-Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4
$


On-tree build, detached HEAD at 144e082:

$ git checkout -f 144e082 && patch -i
/tmp/0001_use-git-symbolicref-for-revno-branch-v2.patch && ./autogen.sh &&
CC="ccache gcc" CXX="ccache g++" ./configure --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook && make

...Output omitted...

$ gui/gtk-gnash --version
Gnash 0.8.11dev (none-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.

Build options
Renderers: agg cairo opengl
Hardware Acceleration: RawFB
GUI: GTK
Media handlers: ffmpeg gst
Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
CXXFLAGS: -g -O2 -std=c++11 -W -Wall -Wcast-qual
-Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4
$


Off-tree build, 144e082 on `master` branch:

$ git checkout -f master && patch -i
/tmp/0001_use-git-symbolicref-for-revno-branch-v2.patch && ./autogen.sh &&
mkdir -p /tmp/gnash-build && cd /tmp/gnash-build && CC="ccache gcc"
CXX="ccache g++" ~/prog/gnash.git/configure --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook && make

...Output omitted...

$ gui/gtk-gnash --version
Gnash 0.8.11dev (master-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.

Build options
Renderers: agg cairo opengl
Hardware Acceleration: RawFB
GUI: GTK
Media handlers: ffmpeg gst
Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
CXXFLAGS: -g -O2 -std=c++11 -W -Wall -Wcast-qual
-Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4
$


Off-tree build, detached HEAD at 144e082:

$ git checkout -f 144e082 && patch -i
/tmp/0001_use-git-symbolicref-for-revno-branch-v2.patch && ./autogen.sh &&
mkdir -p /tmp/gnash-build && cd /tmp/gnash-build && CC="ccache gcc"
CXX="ccache g++" ~/prog/gnash.git/configure --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook && make

...Output omitted...

$ gui/gtk-gnash --version
Gnash 0.8.11dev (none-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.

Build options
Renderers: agg cairo opengl
Hardware Acceleration: RawFB
GUI: GTK
Media handlers: ffmpeg gst
Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
CXXFLAGS: -g -O2 -std=c++11 -W -Wall -Wcast-qual
-Wpointer-arith -Wreturn-type -Wnon-virtual-dtor -Wunused
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4
$


You would see that the version displays are now showing expected branch
nickname in both normal and detached-HEAD repository, and in both on-tree and
off-tree build configuration.

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Sandro Santilli
2017-03-08 10:08:40 UTC
Permalink
Update of bug #50462 (project gnash):

Status: None => Fixed
Assigned to: None => strk
Open/Closed: Open => Closed

_______________________________________________________

Follow-up Comment #10:

Pushed as 2383a5618a88db2c94c3b593a12ed020b8657bea

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?50462>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/

Loading...